Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new encoder delay configuration to let users tune Opus encoder frame delay for latency vs. quality.
- Introduce
EncoderDelayKeyinTurboAudioStreamMod - Wire
EncoderDelaythrough config, engine init, and stream patch - Update README and bump package version
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TurboAudioStream/TurboAudioStreamMod.cs | Register EncoderDelayKey and apply its value in ApplyConfiguration |
| TurboAudioStream/TurboAudioStreamConfig.cs | Add DefaultEncoderDelay constant and EncoderDelay field |
| TurboAudioStream/Patches/AudioStreamInterface_SetAudioStream_Patch.cs | Apply EncoderDelay to the Opus stream and include it in debug log |
| README.md | Document the new EncoderDelay setting and its options |
| Directory.Build.props | Bump package version from 0.0.0 to 0.1.0 |
Comments suppressed due to low confidence (1)
TurboAudioStream/Patches/AudioStreamInterface_SetAudioStream_Patch.cs:62
- The new
EncoderDelayapplication isn't covered by existing tests. Consider adding unit or integration tests to verify thatEncoderDelayKeyis read correctly and applied to the stream.
stream.EncoderDelay.Value = TurboAudioStreamConfig.EncoderDelay;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.