Skip to content

Comments

Add encoder delay#1

Merged
esnya merged 2 commits intomasterfrom
feature/encoder-delay
May 30, 2025
Merged

Add encoder delay#1
esnya merged 2 commits intomasterfrom
feature/encoder-delay

Conversation

@esnya
Copy link
Owner

@esnya esnya commented May 30, 2025

No description provided.

@esnya esnya added the enhancement New feature or request label May 30, 2025
@esnya esnya requested a review from Copilot May 30, 2025 17:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new encoder delay configuration to let users tune Opus encoder frame delay for latency vs. quality.

  • Introduce EncoderDelayKey in TurboAudioStreamMod
  • Wire EncoderDelay through config, engine init, and stream patch
  • Update README and bump package version

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
TurboAudioStream/TurboAudioStreamMod.cs Register EncoderDelayKey and apply its value in ApplyConfiguration
TurboAudioStream/TurboAudioStreamConfig.cs Add DefaultEncoderDelay constant and EncoderDelay field
TurboAudioStream/Patches/AudioStreamInterface_SetAudioStream_Patch.cs Apply EncoderDelay to the Opus stream and include it in debug log
README.md Document the new EncoderDelay setting and its options
Directory.Build.props Bump package version from 0.0.0 to 0.1.0
Comments suppressed due to low confidence (1)

TurboAudioStream/Patches/AudioStreamInterface_SetAudioStream_Patch.cs:62

  • The new EncoderDelay application isn't covered by existing tests. Consider adding unit or integration tests to verify that EncoderDelayKey is read correctly and applied to the stream.
        stream.EncoderDelay.Value = TurboAudioStreamConfig.EncoderDelay;

@esnya esnya merged commit a229c56 into master May 30, 2025
3 checks passed
@esnya esnya deleted the feature/encoder-delay branch May 30, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant