fix: use explicit split positioning to ignore user's splitright setting #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace 'vsplit' with 'rightbelow vsplit' to ensure consistent window layout regardless of user's splitright option. This fixes an issue where users without 'set splitright' would get inverted diff layouts. Fixes issue reported by daliusd_ on Reddit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
set splitrightin their configvsplitwith explicitrightbelow vsplitto guarantee consistent behaviorProblem
The previous code used
vsplitwhich respects the user'ssplitrightoption:set splitright(like the maintainer) got correct layoutset nosplitrightgot inverted layout (modified on left, original on right)Solution
Use explicit positioning commands that ignore
splitright:rightbelow vsplit- always puts new window on RIGHTleftabove vsplit- always puts new window on LEFTTesting
--cleanconfig (no user settings)Credit
Issue reported by daliusd_ on Reddit