fix: use cwd for git repo detection in explorer mode #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r mode Explorer mode now uses vim.fn.getcwd() to detect the git repository, matching the expected behavior when user runs :CodeDiff from a directory. This fixes the case where the current buffer is from a different repo than the working directory.
esmuellert
force-pushed
the
dev/main
branch
2 times, most recently
from
06b946c to
e3d4fb6
Compare
Try buffer path first, then fallback to cwd if buffer path is not in a git repo. This maintains backward compatibility while fixing the case where user has a file open from a different location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix git repository detection in explorer mode to use current working directory instead of current buffer's path.
Problem
When the current buffer is from a different repository than the working directory,
:CodeDiffwould show "not in a git repository" error because it was detecting based on the buffer's path.Solution
Use
vim.fn.getcwd()instead of buffer path for explorer mode, matching howgit statusworks in terminal.No Regression