fix has and use undefined instead of null#147
Open
Mara-Li wants to merge 6 commits intoeslachance:mainfrom
Open
fix has and use undefined instead of null#147Mara-Li wants to merge 6 commits intoeslachance:mainfrom
has and use undefined instead of null#147Mara-Li wants to merge 6 commits intoeslachance:mainfrom
Conversation
miichom
reviewed
Jan 26, 2026
Contributor
|
I noticed the the describe('has', () => {
const enmap = new Enmap({ inMemory: true });
test('should return true if key exists', () => {
enmap.set('has', 'value');
expect(enmap.has('has')).toBe(true);
});
+ test('should return true if key and path exists', () => {
+ enmap.set('hasPath', 'value', 'nested');
+
+ expect(enmap.has('hasPath', 'nested')).toBe(true);
+ });
test("should return false if key doesn't exist", () => {
expect(enmap.has('unknown')).toBe(false);
});
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on the discord:
undefinedwhen a value was not found/present. I created my bots (I use enmap on each! Great works!) around this because I use a lot optional (x?: string) that leads to strictlyundefined. Typescript doesn't allow to setundefined = nulllike in Javascript. It leads to a breaking change in my base so... I changed the value returned.hasdoesn't work in 6.1.5 andpathwas not accepted:Result:
Welcome Message: Welcome to the server! | Present: false