Conversation
bartekgorny
force-pushed
the
dialyzer_fixes
branch
from
8ac623a to
af85ef7
Compare
bartekgorny
force-pushed
the
dialyzer_fixes
branch
2 times, most recently
from
9d78825 to
88e123a
Compare
fen-pl
reviewed
Jan 5, 2026
chrzaszcz
reviewed
Jan 7, 2026
Member
chrzaszcz
left a comment
chrzaszcz
left a comment
There was a problem hiding this comment.
I added a few additional comments.
chrzaszcz
reviewed
Jan 8, 2026
chrzaszcz
reviewed
Jan 8, 2026
bartekgorny
force-pushed
the
dialyzer_fixes
branch
from
3f952cd to
623139d
Compare
fen-pl
approved these changes
Jan 12, 2026
chrzaszcz
requested changes
Jan 13, 2026
bartekgorny
force-pushed
the
dialyzer_fixes
branch
from
335abb4 to
3efeeba
Compare
chrzaszcz
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some specs were correct enough for to pass Dialyzer check on escalus itself, but not on MongooseIM, this PR fixes it.