Allow custom stream element attributes (+ equivalent for WS)#281
Merged
Allow custom stream element attributes (+ equivalent for WS)#281
Conversation
chrzaszcz
force-pushed
the
customizable-stream-element
branch
3 times, most recently
from
c9023b0 to
87906b6
Compare
These attributes apply to: - <stream:stream> tag for TCP - <open> and <close> elements for Websockets Additionally, facilitate testing error conditions by allowing the 'undefined' value for the server and attributes. Such values result in the attributes being removed from the respective element.
chrzaszcz
force-pushed
the
customizable-stream-element
branch
from
87906b6 to
f611708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow custom stream element attributes.
These attributes apply to:
<stream:stream>tag for TCP<open>and<close>elements for WebsocketsAdditionally, facilitate testing error conditions by allowing the
undefinedvalue for the server JID and attributes.Such values result in the attributes being removed from the respective element.