Conversation
kamilwaz
force-pushed
the
sasl-channel-binding
branch
from
e664958 to
ea1b785
Compare
|
CircleCI results for ea1b785 elasticsearch_and_cassandra_latest / elasticsearch_and_cassandra_mnesia / 2ee3e50 small_tests_latest / small_tests / 2ee3e50 small_tests_legacy / small_tests / 2ee3e50 small_tests_latest_arm64 / small_tests / 2ee3e50 ldap_mnesia_legacy / ldap_mnesia / 2ee3e50 ldap_mnesia_latest / ldap_mnesia / 2ee3e50 internal_mnesia_latest / internal_mnesia / 2ee3e50 dynamic_domains_mysql_redis_latest / mysql_redis / 2ee3e50 dynamic_domains_pgsql_mnesia_legacy / pgsql_mnesia / 2ee3e50 dynamic_domains_pgsql_mnesia_latest / pgsql_mnesia / 2ee3e50 pgsql_cets_latest / pgsql_cets / 2ee3e50 cockroachdb_cets_latest / cockroachdb_cets / 2ee3e50 mysql_redis_latest / mysql_redis / 2ee3e50 pgsql_mnesia_latest / pgsql_mnesia / 2ee3e50 pgsql_mnesia_legacy / pgsql_mnesia / 2ee3e50 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4631 +/- ##
==========================================
+ Coverage 86.03% 86.06% +0.03%
==========================================
Files 566 566
Lines 33926 33936 +10
==========================================
+ Hits 29187 29207 +20
+ Misses 4739 4729 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kamilwaz
force-pushed
the
sasl-channel-binding
branch
2 times, most recently
from
a293707 to
6da7cbe
Compare
Apple introduced additional requirements for trusted certificates in iOS 13 and macOS 10.15. To trust a certificate (even self-signed), it must comply with these requirements. Source: https://support.apple.com/en-us/103769
kamilwaz
force-pushed
the
sasl-channel-binding
branch
3 times, most recently
from
7e6de44 to
d7b0497
Compare
kamilwaz
force-pushed
the
sasl-channel-binding
branch
from
d7b0497 to
2ec65b4
Compare
chrzaszcz
left a comment
chrzaszcz
left a comment
There was a problem hiding this comment.
Looks good in general. I added questions about downgraded deps.
kamilwaz
force-pushed
the
sasl-channel-binding
branch
from
2ec65b4 to
2ee3e50
Compare
The certificates used for MIM were broken by #4631. Erlang verifies `serverAuth` against `keyUsage`, which causes the `ssl_certificate:verify_extkeyusage/2` function to fail. The issue wasn't noticed immediately because the certificates are cached using a key generated by `tools/make-certs-cache-key.sh`
The certificates used for MIM were broken by #4631. Erlang verifies `serverAuth` against `keyUsage`, which causes the `ssl_certificate:verify_extkeyusage/2` function to fail. The issue wasn't noticed immediately because the certificates are cached using a key generated by `tools/make-certs-cache-key.sh`
The certificates used for MIM were broken by #4631. Erlang verifies `serverAuth` against `keyUsage`, which causes the `ssl_certificate:verify_extkeyusage/2` function to fail. The issue wasn't noticed immediately because the certificates are cached using a key generated by `tools/make-certs-cache-key.sh`
The certificates used for MIM were broken by #4631. Erlang verifies `serverAuth` against `keyUsage`, which causes the `ssl_certificate:verify_extkeyusage/2` function to fail. The issue wasn't noticed immediately because the certificates are cached using a key generated by `tools/make-certs-cache-key.sh`
3 participants
This PR introduces the following changes:
Requires: esl/escalus#283, esl/fast_scram#17