Skip to content
This repository was archived by the owner on Jan 22, 2018. It is now read-only.

Fix p4 submit losing changelists.#21

Open
gamepoet wants to merge 1 commit intoermshiperete:masterfrom
gamepoet:p4-submit-loses-changelists
Open

Fix p4 submit losing changelists.#21
gamepoet wants to merge 1 commit intoermshiperete:masterfrom
gamepoet:p4-submit-loses-changelists

Conversation

@gamepoet
Copy link

'git p4 submit' was updating the p4/master ref and the git-p4 notes
after a successful submission. As a result any changes between the last
'git p4 sync' and 'git p4 submit' would not get sync'd upon future 'git
p4 syncs' because git-p4 would think that the local repository was
sync'd up to the submitted revision. This change does not update the
local repository and instead forces you to 'git p4 sync' to sync your
new changes from the p4 depot.

Review on Reviewable

'git p4 submit' was updating the p4/master ref and the git-p4 notes
after a successful submission. As a result any changes between the last
'git p4 sync' and 'git p4 submit' would not get sync'd upon future 'git
p4 syncs' because git-p4 would think that the local repository was
sync'd up to the submitted revision. This change does not update the
local repository and instead forces you to 'git p4 sync' to sync your
new changes from the p4 depot.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant