Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Fix: colored nicknames for new info messages design#663

Closed
bews wants to merge 0 commit intoerming:masterfrom
bews:master
Closed

Fix: colored nicknames for new info messages design#663
bews wants to merge 0 commit intoerming:masterfrom
bews:master

Conversation

@bews
Copy link

@bews bews commented May 10, 2016

Now they're colored too (if colored nicknames option is enabled).

2016-05-05_08-19-44

@astorije
Copy link
Collaborator

astorije commented May 10, 2016

@bews, do you mind re-opening this on The Lounge as well? We are missing this over there and that would be a great addition!

I believe this is the case, but just double-checking this:
Are the colors in the action strings (joins, quits, ...) the same than the ones for message authorship?
That is, if I join and then post a message, will the color be the same?

Also, careful, you have an unintended commit here Well, 2 unintended commits now :-)

@bews
Copy link
Author

bews commented May 10, 2016

Also, careful, you have an unintended commit here :-)

Already noticed :)

Are the colors in the action strings (joins, quits, ...) the same than the ones for message authorship?
That is, if I join and then post a message, will the color be the same?

Yep.

@astorije
Copy link
Collaborator

Already noticed :)

Now you have 2 :-)

git rebase -i master
# Remove the last 2 commits and save
git push --force

@dgw
Copy link

dgw commented May 10, 2016

Ah, the perils of making PRs from your master branch.

@bews
Copy link
Author

bews commented May 10, 2016

Recreated from branch - #664

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants