This repository was archived by the owner on Dec 16, 2022. It is now read-only.
RFC: Adding LDAP authentication support#653
Open
doanac wants to merge 3 commits intoerming:masterfrom
Open
Conversation
added 3 commits
February 19, 2016 22:38
By adding an optional "token" parameter to the findClient method, we can simplify the logic of the auth function. Signed-off-by: Andy Doan <andy.doan@linaro.org>
This uses a callback mechanism to fit the needs of the upcoming LDAP authentication function. Signed-off-by: Andy Doan <andy.doan@linaro.org>
This allows logins to authenticate against an LDAP server. If the user doesn't exist before hand they will be created dynamically. Signed-off-by: Andy Doan <andy.doan@linaro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an RFC to get your thoughts on adding an LDAP authentication backend to Shout. I've tried to break this up into small changes to make it easy to follow.
I'd like to add more functionality around LDAP (populating more config fields), but would like to get a feel for the general thoughts around this before proceeding.