This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Add dummy method to forms (quiets LastPass)#649
Open
maxpoulin64 wants to merge 1 commit intoerming:masterfrom
maxpoulin64:lastpass
Open
Add dummy method to forms (quiets LastPass)#649maxpoulin64 wants to merge 1 commit intoerming:masterfrom maxpoulin64:lastpass
maxpoulin64 wants to merge 1 commit intoerming:masterfrom
maxpoulin64:lastpass
Conversation
It appears LastPass looks for the use of the GET method in forms on the page to determine if it is secure or not. Since Shout never actually submits any of the forms, no method is set, which means the default of GET is used. Changes form methods to POST to quiet the warning. Should fix #648
Contributor
|
Huh, that seems like a very brittle way of figuring things out from lastpass's view of things. But whatever. Yeah, seems like a good fix. |
Collaborator
|
FYI, this has been moved over to The Lounge: thelounge/thelounge#19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears LastPass looks for the use of the GET method in forms on the page to determine if it is secure or not. Since Shout never actually submits any of the forms, no method is set, which means the default of GET is used. Changes form methods to POST to quiet the warning. Should fix #648