This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Split favicon badge and desktop notifications settings#645
Open
lpoujol wants to merge 1 commit intoerming:masterfrom
lpoujol:settings-split-badge-notifications
Open
Split favicon badge and desktop notifications settings#645lpoujol wants to merge 1 commit intoerming:masterfrom lpoujol:settings-split-badge-notifications
lpoujol wants to merge 1 commit intoerming:masterfrom
lpoujol:settings-split-badge-notifications
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #512
Now the "badge" setting is for the favicon badge and desktop notification has his own checkbox on the settings page