fix: disable reload button if discarded selected#131
Open
dnwe wants to merge 3 commits intoericpromislow:masterfrom
Open
fix: disable reload button if discarded selected#131dnwe wants to merge 3 commits intoericpromislow:masterfrom
dnwe wants to merge 3 commits intoericpromislow:masterfrom
Conversation
ericpromislow
requested changes
Oct 14, 2024
Owner
ericpromislow
left a comment
ericpromislow
left a comment
There was a problem hiding this comment.
While you're working on this, could you also ensure the Reload button is disabled when no tabs are selected?
This change seemed to have been published under 3.6.2 to the Firefox add-ons, but wasn't included in the GitHub source so backporting it to here.
Addressing a regression in 3.6.2 whereby the reload button was inadvertently enabled when no items were selected. Also fixup the doReloadTabs action so it filters-out discarded items rather than filters them in.
Contributor
Author
|
Sure, have added a commit to fix that. During testing I also noted that the doReloadTabs on the released version on the firefox store had inadvertently filtered-in discarded tabs rather than filtered them out, so the reload button wasn't having any effect. That's fixed on this branch too now |
Owner
|
It's not working for me on firefox -- when I select a grayed-out line, the Reload button is disabled. When I select an active line, the button is enabled. I always intended this button to replenish discarded tabs, but it could also be used to reload active ones. So it would be better if it's never disabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change seemed to have been published under 3.6.2 to the Firefox add-ons, but wasn't included in the GitHub source so backporting it to here and bumping the VERSION= number to match the release