Add support for Arch and Envs for nfpm_package.#8
Open
sfc-gh-ptabor wants to merge 3 commits intoericnorris:mainfrom
Open
Add support for Arch and Envs for nfpm_package.#8sfc-gh-ptabor wants to merge 3 commits intoericnorris:mainfrom
sfc-gh-ptabor wants to merge 3 commits intoericnorris:mainfrom
Conversation
Refreshed the dependencies in the project to make it Bazel 7 buildable. Renamed go/v2 directory to be compatible with golang naming convention for code versioning. cd go/v2 && go build ./... works without complaining. Applied current gazelle behaviour that generate build files in any directory. Made sure stardoc and buildifier still work Note: On my linux I had to use: CC=clang bazel build ... --sandbox_writable_path=$HOME/.ccache --sandbox_writable_path=/run/user to build it and avoid information about missing ld or being unable to write caches.
1. Arch allows to build multiple variants of package using different architectures, thanks to Bazel transitions from the same definition (https://bazel.build/rules/lib/builtins/transition). 2. Envs is a common way for passing bazel level data to templates (like the config). It supports location expansion: https://bazel.build/rules/lib/builtins/ctx#expand_location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Please see the last commit only... as I cannot select the base branch]