This repository was archived by the owner on Feb 10, 2019. It is now read-only.
Moved attaching library patterns from bindDelegation to validate#81
Open
danneenee wants to merge 1 commit intoericelliott:masterfrom
Open
Moved attaching library patterns from bindDelegation to validate#81danneenee wants to merge 1 commit intoericelliott:masterfrom
danneenee wants to merge 1 commit intoericelliott:masterfrom
Conversation
Moved attaching patterns from library to elements from bindDelegation to validate. Added the ability to combine custom patterns set for elements with the use of the pattern library. The validation uses both the custom pattern and the pattern pulled from the library if combineClassName in settings is true. Otherwise, it defaults to the custom pattern if it exists, followed by the one found in the pattern library if it doesn't. We needed this because in bindDelegation it was just overwriting custom validation that was in place with the pattern attribute. This way you can still use both validations.
Owner
|
How about some unit tests? |
Owner
|
This needs unit tests that illustrate that the required functionality works correctly, or it can't be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved attaching patterns from library to elements from bindDelegation to validate. Added the ability to combine custom patterns set for elements with the use of the pattern library. The validation uses both the custom pattern and the pattern pulled from the library if combineClassName in settings is true. Otherwise, it defaults to the custom pattern if it exists, followed by the one found in the pattern library if it doesn't.
We needed this because in bindDelegation it was just overwriting custom validation that was in place with the pattern attribute. This way you can still use both validations.