Skip to content

Conversation

@ReaktorDTR
Copy link

@ReaktorDTR ReaktorDTR commented May 30, 2021

Closes #673
Added: Copy time column in analyzer
Updated: Total time includes Copy time


# Rename plot. Sample log line:
# Renamed final file from "/mnt/d1/a4.plot.2.tmp" to "/mnt/d2/a4.plot"
m = re.search(r'^Renamed final file.*', line)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this present regardless of what combinations of tmp/tmp2/dst are specified?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and if tmp same as dst it will show 0 sec because of simple renaming.

@altendky
Copy link
Collaborator

I'm a bit hesitant to have total time in analyze mean a different thing than total time in the logs. Any ideas what else would be a good name for the combination? Having total, copy, and combined time would allow the output code to stay more like before but just add the two new bits.

Do you have a log you could share that shows the copy time? My most recent logs don't include it. They should have been from 1.1.7. I have tmp the same as dst so there's no copying so it's understandable.

@ReaktorDTR
Copy link
Author

It might be called Summary. I don't have logs for 1.1.7. When I got the first numbers in the Copy Time column I made a decision to switch from separate folders to one for all 😄

@altendky
Copy link
Collaborator

How about we just go literal with start + copy. I think that still ends up about the same length as the data in the table cells. If there's inspiration later it can change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants