refactor!: consolidate all drift diffusion based collision operators #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to go over the tests, they are purely done by Claude but seem pretty robust, though I haven't even read them! 🙈
Nevertheless, I'm pretty happy with the overall design which leaves open the door to many opportunities for other models, algorithms and heating/cooling physics.
Key numerical changes these affect vfp1d, _vlasov1d and vlasov1d2v (vlasov2d unaffected for now):
Limitations:
Choices: