Skip to content

Conversation

@howydev
Copy link
Collaborator

@howydev howydev commented Dec 10, 2024

The term "validation associated hooks" could potentially be confusing as it sounds like the hooks are run whenever a specific validation function are run. However, the hooks are actually associated to an entity, referenced by a (validation module + entity id) pair

I suggest we improve the framing to be around "entity associated hooks" as that's more accurate. This PR changes the variable names and comments to use "module entity associated hooks"

@howydev howydev requested a review from jaypaik December 10, 2024 17:29
@octane-security-app
Copy link

octane-security-app bot commented Dec 10, 2024

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • AccountStorage.sol: Modified execution hooks to be entity-specific, triggering when the validation is used.
  • ReferenceModularAccount.sol: Renamed "Validator" to "Entity" in execution and runtime hook logic, improving clarity.
  • Constants.sol: Changed "validation-associated" to "entity-associated" hooks, indicating broader functionality.
  • IExecutionHookModule.sol: The smart contract modification changes "validation-associated hooks" to "entity associated hooks" in the pre-execution functionality.

🔗 Commit Hash: dd3fe66

@octane-security-app

This comment was marked as resolved.

@howydev howydev force-pushed the howy/rename-exechook-association branch from 95e9102 to dd3fe66 Compare December 11, 2024 03:14
@howydev howydev closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants