-
Notifications
You must be signed in to change notification settings - Fork 40
Hailstorm Zone #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Hailstorm Zone #199
Conversation
| } | ||
|
|
||
| @Override | ||
| public void registerEncounters() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do this and use getNormalEncounters? Only using getNormalEncounters is probably better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was to test it, it is not supposed to be used. I'll comment it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove it, don't comment it
|
|
||
| @Override | ||
| public List<ZoneEncounter> getNormalEncounters() { | ||
| return Collections.singletonList( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to make 3 encounters (you can use base game enemies in them as well) having only a single one will get boring quick
|
|
||
| @Override | ||
| public float zoneSpecificEventRate() { | ||
| return 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also use
@Override
public String forceEvent() {
return ModifiedEventRateZone.returnIfUnseen(YourEvent.ID);
}
That will force the first event to be your event and let following events be normal. Repeating the same even over and over isn't great.
| @@ -0,0 +1,56 @@ | |||
| // | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these comments
src/main/resources/anniv6Resources/localization/eng/Hailstorm/Cardstrings.json
Outdated
Show resolved
Hide resolved
src/main/resources/anniv6Resources/localization/eng/Hailstorm/Cardstrings.json
Outdated
Show resolved
Hide resolved
| "NAME": "Ice Burn", | ||
| "DESCRIPTION": "Unplayable. NL At the end of your turn, take !M! damage." | ||
| }, | ||
| "${ModID}:IcicleSpear": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove the string please
| }, | ||
| "${ModID}:HailEffect": { | ||
| "TEXT": [ | ||
| "At the start of the first #b3 turns, EVERYONE gains #b4 #yBlock. NL After these #b3 turns, at the end of each turn EVERYONE takes #b4 damage, increased by #b1 every turn." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the end of each turn means twice every round?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, once per round.
I figured I'd use turn since "round" is not base game used, but I'll take any suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use at the end of the monster's turn then or something
| private int screenNum = 0; | ||
|
|
||
|
|
||
| public AbandonedCamp() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better if you made a custom relic instead of dead branch. It can be a simple one like The first time you deal damage each combat, deal 12 damage to ALL enemies. for like a frozen stick.
Just think that Dead Branch is very polarizing and giving direct access to it is something wed'd like to avoid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We alr went through this discussion. I personally wanted to give access to this relic as it is very thematic on top of being fun.
It is not a guarantee drop.
Also I think people created way more polarizing stuff (mainly from my experience with PM i didn't play much biomes).
I think it will bring more enjoyment than cutting it
…Cardstrings.json Co-authored-by: erasels <emanuelbedburdick@yahoo.de>
…Cardstrings.json Co-authored-by: erasels <emanuelbedburdick@yahoo.de>
Hi,
Finally I think I'm done, I can't be 100% sure everything is working is working perfectly but I've done some testing ofc, tho I'd recommend someone going over code just in case, given I have spread the workload on multiple weeks.
I haven't done a Bestiary entry for my slime as I'm kind of getting tired by this project, However it's a classic slime, behavior taken from base game.
Thank you again for putting this together