fix: sync DISPLAY_VERSION with CLIENT_VERSION (0.4→0.7)#2
Closed
s1ko wants to merge 1 commit intoepsylon:masterfrom
Closed
fix: sync DISPLAY_VERSION with CLIENT_VERSION (0.4→0.7)#2s1ko wants to merge 1 commit intoepsylon:masterfrom
s1ko wants to merge 1 commit intoepsylon:masterfrom
Conversation
DISPLAY_VERSION_MINOR in version.h was still set to 4 while clientversion.h was updated to 7. This caused ecoind to report itself as v0.4.5.7 to the network instead of v0.7.5.7, preventing proper chain synchronization with peers running the current version.
There was a problem hiding this comment.
Pull request overview
Synchronizes the human-readable/displayed client version with the already-updated internal client version macros so the node reports the correct v0.7.5.7-… identifier on the network.
Changes:
- Update
DISPLAY_VERSION_MINORfrom4to7to matchCLIENT_VERSION_MINOR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
fixed at new release 0.0.4. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
DISPLAY_VERSION_MINORinsrc/version.hwas still set to4whileclientversion.hwas correctly updated to7.This caused
ecoindto identify itself asv0.4.5.7-ga-betato the network instead ofv0.7.5.7-ga-beta.Impact
Fix
One-line change:
DISPLAY_VERSION_MINOR 4→DISPLAY_VERSION_MINOR 7insrc/version.hto matchclientversion.h.Tested on Debian 12 (kernel 6.17), compiled and verified: node now reports
v0.7.5.7-ga-betaand syncs correctly with the network.