Skip to content

Conversation

@tkla
Copy link

@tkla tkla commented Jun 8, 2022

Updated EnvoyAPI with additional methods to be consistent with the public APIs we have available.

Also added axios package. In the future we should update the requests to axios to move away from the nodeJS Request library which is now deprecated.

Copy link
Author

@tkla tkla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed one of my commits breaks any app importing this SDK and deployed in Heroku due to an unexpected token error. I corrected this at 259ad68 and was able to confirm it fixed when testing with an app hosted on my Heroku.

@tkla tkla assigned tkla and unassigned tkla Jun 16, 2022
@tkla tkla self-assigned this Jun 16, 2022
@tkla
Copy link
Author

tkla commented Jun 16, 2022

Hello @anthonyFloccari and @johnmarrero,

Would either of you be able to help review this PR? Let me know if this should be assigned to someone else to review and I'll reach out to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants