Skip to content

Conversation

@tlk
Copy link

@tlk tlk commented Dec 14, 2019

README.md has examples on how to use DataReader, JSONReader and URLParametersReader and the instructions says that the example code will wait for input to be read.

However, as explained by @fangpenlin in #18 (comment) the current example code

(..) is meant for returning simple data without any async operation, that's why it won't wait for reading POST data body or any other HTTP body data

I suggest updating the example code to wait for input and to handle the case of no input at all (see
envoy/Embassy#64).

@tlk
Copy link
Author

tlk commented Dec 14, 2019

Refs #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant