Merged
Conversation
Max-Reeves
force-pushed
the
max/shield/jwt-version-support
branch
from
4b3c608 to
6eaa6b6
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for additional JWT minor versions by updating the test suite, gemfiles, and documentation.
- Added test context for JWT version 3.x.x
- Updated gemfiles to include versions 2.9.0, 2.10.0, 3.0.0, and 3.1.0
- Bumped the library version from 4.0.0 to 4.1.0 and updated the changelog accordingly
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/jwt_signed_request/verify_spec.rb | Added tests for verifying behavior with JWT version 3.x.x |
| lib/jwt_signed_request/version.rb | Updated version bump from 4.0.0 to 4.1.0 |
| gemfiles/jwt_3.1.0.gemfile, jwt_3.0.0.gemfile, etc | Added gemfiles for additional JWT versions |
| CHANGELOG.md | Updated changelog and documentation for version 4.1.0 changes |
| Appraisals | Added new JWT versions for test matrix inclusion |
| .github/workflows/test.yml | Updated CI configuration with new JWT test jobs |
| stub_const("JWT::VERSION::MAJOR", 3) | ||
| end | ||
|
|
||
| it 'raises an a MissingAlgorithmError' do |
There was a problem hiding this comment.
There is a typo in the test description. Consider revising it to 'raises MissingAlgorithmError' to remove the extra article.
Suggested change
| it 'raises an a MissingAlgorithmError' do | |
| it 'raises MissingAlgorithmError' do |
4-Eyes
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
https://envato.atlassian.net/jira/software/c/projects/CAM/boards/607?selectedIssue=CAM-2365
This pull request adds support for additional JWT minor versions by updating the test suite, gemfiles, and documentation.
Added test context for JWT version 3.x.x
Updated gemfiles to include versions 2.9.0, 2.10.0, 3.0.0, and 3.1.0
Bumped the library version from 4.0.0 to 4.1.0 and updated the changelog accordingly
Heads up!
PRs that go 60 days without activity may be automatically closed. See these docs for more information.