Compute defaultValue on client-side #4234
#4238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@anatol-sialitski I've opened a new pull request, #4239, to work on those changes. Once the pull request is ready, I'll request review from you. |
rymsha
approved these changes
Jan 19, 2026
alansemenov
reviewed
Jan 19, 2026
Comment on lines
33
to
35
| getDefaultValueFromConfig(): Value; | ||
|
|
||
| getRawDefaultFromConfig(): unknown; |
Member
There was a problem hiding this comment.
It shouldn't matter where default value is coming from, so I suggest calling it simply getDefaultValue and getRawDefaultValue
Contributor
Author
There was a problem hiding this comment.
I do not agree. That is a raw value which can be computed later. For instance, for the instant type, we can use a now expression as a default value, and that expression will be computed to an ISO string.
alansemenov
approved these changes
Jan 19, 2026
anatol-sialitski
added a commit
that referenced
this pull request
Jan 22, 2026
anatol-sialitski
added a commit
that referenced
this pull request
Jan 22, 2026
anatol-sialitski
added a commit
that referenced
this pull request
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.