Skip to content

Ocapn: Snapshot test for exported types #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kumavis merged 15 commits into from
Feb 10, 2026
Merged

Ocapn: Snapshot test for exported types #3041

kumavis merged 15 commits into from
Feb 10, 2026

Conversation

@kumavis
Copy link
Member

@kumavis kumavis commented Jan 7, 2026 •
edited
Loading

  • Fixes python test flake (reproduced via removed flake-forcing loop test seen here)
  • Introduces Snapshot test for public API type tree
  • Refactors to reduce public API
  • Adds a snapshot test for public type tree (example here)

@kumavis kumavis marked this pull request as ready for review January 9, 2026 01:11
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 26027dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kumavis added 15 commits February 9, 2026 15:35
@kumavis
fix(ocapn): immediately end session on abort
3f4f35b
@kumavis
test(ocapn): update python test suite to main
c0c484e
@kumavis
refactor(ocapn): remove unused comms kit abort fn
9c6852b
@kumavis
refactor(ocapn): cleanup comms kit
9bd28af
@kumavis
feat(ocapn): improve logging and error messages
4f3a098
@kumavis
refactor(ocapn): break out handshake from client
e1711ab
@kumavis
refactor(ocapn): simplify handshake args via prepareOcapn fn
a54343e
@kumavis
test(ocapn): snapshot of public api type tree
7724dc0
@kumavis
refactor(ocapn): underscore-prefix ocapn._debug + ignore in api-surfa…
cc0e1a6 
…ce test
@kumavis
refactor(ocapn): registerNetlayer constructs the NetLayer in the prov…
266e689 
…ided factory fn
@kumavis
fix(ocapn): in api-surface test properly handle template types
7773b1a
@kumavis
refactor(ocapn): add client._debug to reduce public api
891eceb
@kumavis
refactor(ocapn): provide minimal session for public api
4350c5a
@kumavis
refactor(ocapn): NetLayer calls makeConnection with SocketOperations
152d218
@kumavis
refactor(ocapn): for crypto prefer assertValid over verify
26027dd
@kriskowal kriskowal changed the title Ocapn: more Ocapn: Snapshot test for exported types Feb 10, 2026
kriskowal
kriskowal approved these changes Feb 10, 2026
View reviewed changes
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I see that might be worth follow-up is that the tests might be more portable if we adapted the TCP layer to iterator protocol with @endo/stream-node, we might be able to reuse tests in other network layers.

@kumavis kumavis merged commit ad25f00 into master Feb 10, 2026
41 of 42 checks passed
@kumavis kumavis deleted the ocapn-sesh3 branch February 10, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kriskowal kriskowal kriskowal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumavis @kriskowal