Skip to content

Conversation

@mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Nov 28, 2025

Summary

This PR fixes/implements the following bugs

  • The "Expand All" and "Collapse All" buttons do not indicate their disabled state programmatically when all accordions are already expanded or collapsed.The same is indicated visually using a different color
  • The tab widget has the below issues:
    1. It is not programmatically implemented as a proper tab component. Tabs are announced as links by screen readers
    2. The arrow icon used to access remaining tabs is not keyboard-operable, making it inaccessible to keyboard and screen reader users

Tickets

https://app.clickup.com/t/36718269/EMULSIF-438
https://app.clickup.com/t/36718269/EMULSIF-439

How to review this pull request

  • Visit the following https://deploy-preview-179--emulsify-ui-kit.netlify.app/
  • Go to an Accordion and confirm the "Expand All" and "Collapse All" buttons programmatically indicate their disabled state using aria-disabled="true"
  • Now visit Tabs and confirm Tabs are correctly announced as "tabs" by screen readers along with selected state. Users should be able to operate the arrow icon using keyboard

@netlify
Copy link

netlify bot commented Nov 28, 2025

Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit a0878a9
🔍 Latest deploy log https://app.netlify.com/projects/emulsify-ui-kit/deploys/692a022b34fbf800087c8039
😎 Deploy Preview https://deploy-preview-179--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mariannuar mariannuar changed the title Accessibility tweaks EMULSIF-546: Accessibility tweaks Nov 28, 2025
@mariannuar mariannuar self-assigned this Nov 28, 2025
@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👍 Ready for Review Work is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants