EMULSIFY-309: Design tokens for Gallery component #153
Conversation
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mariannuar
added
👉 Needs Work
…ulsify-ui-kit into gallery
mariannuar
added
👍 Ready for Review
robherba
left a comment
robherba
left a comment
There was a problem hiding this comment.
Hey Mari, nice work! Most of the tokens for the gallery component match the Figma design. I just have a couple of small comments:
robherba
added
👉 Needs Work
|
@robherba Thank you for your feedback. This is ready for review again :) |
mariannuar
added
👍 Ready for Review
src/tokens/figma.tokens.json
Outdated
| }, | ||
| "modal": { | ||
| "padding-x": { | ||
| "value": "40", |
There was a problem hiding this comment.
Maybe this part could follow a pattern similar to the padding-bottom token? Also, it might be good to add a unit to this token so it’s not seen as an invalid value—something like "value": "{spacing.2xl}" or "value": "40px".
src/tokens/figma.tokens.json
Outdated
| "type": "spacing" | ||
| }, | ||
| "padding-top": { | ||
| "value": "76", |
There was a problem hiding this comment.
The same applies to this value.
src/tokens/tokens.scss
Outdated
| --header-search-text-icon: #fff; | ||
| --gallery-overlay: #00405b; | ||
| --gallery-grid: 2rem; | ||
| --gallery-heading: #006089; |
There was a problem hiding this comment.
This color seems different from the color of the gallery title in figma.
robherba
added
🎉 Passes Functional Review
josue2591
changed the title
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Design tokens for the new Gallery component
How to review this pull request