Skip to content

Conversation

@mikeethedude
Copy link
Contributor

PR for release to fix component command

@mikeethedude
Copy link
Contributor Author

@callinmullaney Can you double check I'm doing this right?

@callinmullaney
Copy link
Contributor

@mikeethedude Commit structure looks good and the "add ..." tests having been failing on all the Emulsify projects for a while. Since they're pretty inconsequential to releases I've just been ignore them.

The one that you'll need to do is a "chore" commit to bump the release version in the package.json and package-lock.json. We should probably automate this step at some point but for now it's done manually so we can do the npm publish command and push the release to npmjs.com. See how I did this last time: #308

@mikeethedude
Copy link
Contributor Author

@callinmullaney Good call on the version bump! Totally missed that.

Copy link
Contributor

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeethedude
Copy link
Contributor Author

I had to go back and re-sign a commit but now I think we are good.

@mikeethedude mikeethedude merged commit 31ad3d2 into main Dec 4, 2024
4 of 5 checks passed
@github-actions
Copy link

github-actions bot commented Dec 4, 2024

🎉 This issue has been resolved in version 1.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants