This repository was archived by the owner on Dec 21, 2022. It is now read-only.
Added support for tags in ssh_config in the form of '@tag1 @tag2'.#136
Open
groundnuty wants to merge 2 commits intoemre:masterfrom
Open
Added support for tags in ssh_config in the form of '@tag1 @tag2'.#136groundnuty wants to merge 2 commits intoemre:masterfrom
groundnuty wants to merge 2 commits intoemre:masterfrom
Conversation
In order to better manage large numbers of hosts in ssh_config it would be beneficial be able to tag them with project names etc. Now in the 'Host' section of ssh_config one can add a line that starts with a "#" followed (without a spacebar, by a list of tags eg. "#@tag1 @tag2". The 'storm list' command now displays apart from [custom_options] also a [tags] section if flag '-t' is supplied. New 'storm list-tag <tag>' command was added, that displays only Hosts tagged with specific tag, or all tags if no tag is supplied. The test of 'storm list' was modified to test this new functionality.
…ll tags, those substrings will be matched against tags and hosts with those tags will be displayed
Owner
|
awesome. @berkerpeksag can you find time to review this? |
Author
|
any chance to become a collaborator to this project and integrate it myself? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to better manage large numbers of hosts in ssh_config it would be beneficial be able to tag them with project names etc. Now in the 'Host' section of ssh_config one can add a line that starts with a "#" followed (without a spacebar) by a list of tags eg.
#@tag1 @tag2.storm listcommand now displays apart from [custom_options] also a [tags] section if flag '-t' is supplied.storm list-tag <tag>command was added, that displays only Hosts tagged with specific tag, or all tags if no tag is suppliedThe test of 'storm list' command was modified to cover this new functionality.
I did not touch the web interface since I do not use. Those changes do not interfere with it nor change the behaviour of the
storm list(or any other command) if ssh_config does not contain lines in a form of#@tag1...An example ssh/config like that:
Produces such output for the
storm list -tcommand:The
storm list-tag projectx gwcommand returns: