fix: make max restart intensity proportional to pool size #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
20250911-m-fix-sup-down
branch
from
7211e4a to
95b2489
Compare
Previously, we had a fixed restart intensity for the worker supervisor, meaning that if a large pool dies once, it brings down the supervisor. Here, we have an intensity proportional to the pool size, so the whole pool may restart at once without bringing the supervisor down.
thalesmg
force-pushed
the
20250911-m-fix-sup-down
branch
from
95b2489 to
dffa745
Compare
savonarola
reviewed
Sep 11, 2025
savonarola
reviewed
Sep 11, 2025
savonarola
reviewed
Sep 11, 2025
thalesmg
commented
Sep 11, 2025
|
|
||
| %% for backward compatibility upgrading from version =< 4.2.1 | ||
| safe_exec(Action, MainArg) when is_function(Action) -> | ||
| Action(MainArg). |
Contributor
Author
There was a problem hiding this comment.
This was the cause for the crashes: this clause was not catching anything.
savonarola
approved these changes
Sep 11, 2025
thalesmg
added a commit
to thalesmg/emqx
that referenced
this pull request
Sep 12, 2025
3 tasks
thalesmg
added a commit
to thalesmg/ehttpc
that referenced
this pull request
Sep 12, 2025
thalesmg
added a commit
to thalesmg/ehttpc
that referenced
this pull request
Sep 12, 2025
thalesmg
added a commit
to thalesmg/ehttpc
that referenced
this pull request
Sep 12, 2025
See also emqx/ecpool#59 See also https://emqx.atlassian.net/browse/EMQX-14705 Previously, we had a fixed restart intensity for the worker supervisor, meaning that if a large pool dies once, it brings down the supervisor. Here, we have an intensity proportional to the pool size, so the whole pool may restart at once without bringing the supervisor down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had a fixed restart intensity for the worker supervisor, meaning that if a
large pool dies once, it brings down the supervisor. Here, we have an intensity
proportional to the pool size, so the whole pool may restart at once without bringing the
supervisor down.