fix: restart workers that fail to connect during init #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: avoid slow connections block the ecpool_sup
thalesmg
force-pushed
the
fix-restart-worker
branch
3 times, most recently
from
85d0e15 to
5929cd9
Compare
This ports several fixes that were somehow missed from 0.5.12 emqx/ecpool@0.5.10...0.5.12 emqx/ecpool@0.5.12...0.6.0
thalesmg
force-pushed
the
fix-restart-worker
branch
from
5929cd9 to
0bbc92c
Compare
terry-xiaoyu
approved these changes
Dec 6, 2024
thalesmg
force-pushed
the
fix-restart-worker
branch
from
7f3c383 to
785aa38
Compare
terry-xiaoyu
approved these changes
Dec 6, 2024
thalesmg
added a commit
to thalesmg/emqx
that referenced
this pull request
Dec 9, 2024
- mysql-otp : emqx/mysql-otp#14 Brings several fixes from upstream, in particular a case clause error: ``` Generic server <0.23937.0> terminating. Reason: {{case_clause,{error,closed}},[{mysql_protocol,fetch_response,7,[{file,\"mysql_protocol.erl\"},{line,569}]},{mysql_conn,query,4,[{file,\"mysql_conn.erl\"},{line,648}]},{mysql_conn,handle_call,3,[{file,\"mysql_conn.erl\"},{line,316}]},{gen_server,try_handle_call,4,[{file,\"gen_server.erl\"},{line,1131}]},{gen_server,handle_msg,6,[{file,\"gen_server.erl\"},{line,1160}]},{proc_lib,init_p_do_apply,3,[{file,\"proc_lib.erl\"},{line,241}]}]}. ``` - ecpool : emqx/ecpool#57 Fixes that were missed from 0.5.12, to avoid crashing ecpool workers in a tight loop and reach maximum restart intensity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that several fixes were missed from 0.5.12 to 0.6.0.
Weirdly, the diff above does not show some of those changes, such as using
handle_continue, that show up here: 0.5.10...0.5.12