Capture pointblank validation steps in level-2/3 stubs#3
Open
petrbouchal wants to merge 2 commits intoemilyriederer:masterfrom
Open
Capture pointblank validation steps in level-2/3 stubs#3petrbouchal wants to merge 2 commits intoemilyriederer:masterfrom
petrbouchal wants to merge 2 commits intoemilyriederer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue #2 where columns are not captured for pointblank validation steps when the validation condition is specified for level 2 or 3.
I also added some tests, hopefully close enough in approach to your existing ones, but starting from a separate convo so as not to create confusion. I can rewrite them using YAML files if you would like?
What is not clear to me is why your existing tests we