Updating to a more recent gradle to solve generated Resource index va…#56
Open
simonlaalo wants to merge 1 commit intoemilsjolander:masterfrom
Open
Updating to a more recent gradle to solve generated Resource index va…#56simonlaalo wants to merge 1 commit intoemilsjolander:masterfrom
simonlaalo wants to merge 1 commit intoemilsjolander:masterfrom
Conversation
…lue inconsistencies. Specifically, the indexes for stuckShadowDrawable and stuckShadowHeight were transposed at runtime, leading to UnsupportedOperationException: "Can't convert to dimension: type=0x3"UnsupportedOperationException when inflating the layout when used library is used with newer Gradle. Incrementing version number as the build results may not be backwards compatible.
Author
|
I have also commented out the push to the maven repo in my fork, which you will likely want to uncomment in your version |
Osama-Ahmedd
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to a more recent gradle and android build tools to solve generated Resource index value inconsistencies. Specifically, the index values for R.styleable.StickyScrollView_stuckShadowHeight and R.styleable.StickyScrollView_stuckShadowDrawable were transposed at runtime, leading to UnsupportedOperationException: "Can't convert to dimension: type=0x3" when inflating the layout when used library is used with newer Gradle (on line 90 or 98 respectively of StickyScrollView.java) should one or both of these attributes be set in the layout xml.
Incrementing version number as the build results may not be backwards compatible.