Open
Conversation
Add a StickyScrollViewListener to be able to know if the sticky view is shown or hidden
There was a problem hiding this comment.
Please maintain the same spacing rule as source file. They are using tabs as space :-)
|
Well done 👍 . This callback would be nice to have. @emilsjolander - Could you please review!? Thanks |
There was a problem hiding this comment.
Could you please document each callback method and the interface itself.
Owner
There was a problem hiding this comment.
Could you also please declare any interfaces or inner classes at the top of the file?
Owner
|
@mick1418 fix some of the issues me and @amardeshbd have commented on and add something about this in the readme and i'll merge it |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a StickyScrollViewListener to be able to know if the sticky view is
shown or hidden