Update to ureq 3 #76
Merged
Update to ureq 3 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Jan 5, 2026
Contributor
Author
|
You could also consider swapping the |
emilk
approved these changes
Jan 6, 2026
| break; | ||
| } | ||
| }, | ||
| ); |
Owner
There was a problem hiding this comment.
There is a lot of code in common here with ehttp/src/native.rs. Maybe the setup-code could be broken out into a helper function that is used by both places?
emilk
requested changes
Jan 6, 2026
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Actually, HEAD requests are broken in the demo app (cargo run)
chore: clarify the reason for used of `unreachable!()` Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Rather than the simple `std::io::Error::UnexpectedEof`, ureq now uses `std::io::Error::Custom(ureq::Error::Decompress(&str, std::io::Error::UnexpectedEof))`
Contributor
Author
|
HEAD requests have been fixed. I'm quite surprised that a subtle change (see commit description) to how ureq gives errors wouldn't be listed in the migration guide. |
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using the ureq 3 API. The changes include: