allow custom toolbar tooltips on EditControl component#279
Open
fgoudreault wants to merge 2 commits intoemilhe:masterfrom
Open
allow custom toolbar tooltips on EditControl component#279fgoudreault wants to merge 2 commits intoemilhe:masterfrom
fgoudreault wants to merge 2 commits intoemilhe:masterfrom
Conversation
Owner
|
This is a nice addition. And a neat PR. One question; is there a reason you only target the |
Author
|
No particular reasons. I was just looking at these tooltips for my use case. Indeed I guess there could be options for all buttons and one could possibly override the whole |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to propose a new option to the EditControl component which allows to customize the tooltip shown when hovering on the draw buttons. Here's an example screenshot of what it looks like.

MWE: