-
Notifications
You must be signed in to change notification settings - Fork 385
Add VS Code settings and update Makefile #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "recommendations": [ | ||
| "josevseb.google-java-format-for-vs-code", | ||
| "redhat.java" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "java.project.sourcePaths": [ | ||
| "labs/lab0-pingpong/src", | ||
| "labs/lab0-pingpong/tst", | ||
| "labs/lab1-clientserver/src", | ||
| "labs/lab1-clientserver/tst", | ||
| "labs/lab2-primarybackup/src", | ||
| "labs/lab2-primarybackup/tst", | ||
| "labs/lab3-paxos/src", | ||
| "labs/lab3-paxos/tst", | ||
| "labs/lab4-shardedstore/src", | ||
| "labs/lab4-shardedstore/tst", | ||
| ], | ||
| "java.project.referencedLibraries": [ | ||
| "jars/*.jar", | ||
| ], | ||
| "java.compile.nullAnalysis.mode": "automatic", | ||
| "editor.defaultFormatter": "josevseb.google-java-format-for-vs-code", | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't automatically install then, right?
redhat.javaseems fine but I don't love installing for students some plugin maintained by a random guy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it just trigger a popup on the corner like this
I agree that install unpopular extension is concerned, but it's the most efficient (and probably the minimal) way to prevent hitting formatting document shortcut to mess up the template's format (because redhat extension format the code differently from google-java-format, and there's no way to configure it to match the style).
There are multiple VS Code extensions that integrate google-java-format to VS Code, I tried some and found this one is the most recent one and works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, if student chooses to not install the formatting extension, a dialog will show up when formatting the document
Then the student is free to configure the formatter back to redhat (although that is probably not helpful).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the student can always opt-out formatting through VS Code at all and run
make formatdirectly.