Skip to content

Replace depcreated usingLlm method with method arg #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexheifetz merged 1 commit into from
Aug 6, 2025
Merged

Replace depcreated usingLlm method with method arg #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/main/java/com/embabel/template/agent/WriteAndReviewAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,13 @@ ReviewedStory reviewStory(UserInput userInput, Story story, OperationContext con
}

@Action
Story craftStory(UserInput userInput) {
return PromptRunner.usingLlm(
LlmOptions.fromCriteria(AutoModelSelectionCriteria.INSTANCE)
.withTemperature(0.9) // Higher temperature for more creative output
).withPromptContributor(Personas.WRITER)
.createObject(String.format("""
Story craftStory(UserInput userInput, OperationContext context) {
PromptRunner runner = context.promptRunner()
// Higher temperature for more creative output
.withLlm(LlmOptions.fromCriteria(AutoModelSelectionCriteria.INSTANCE, 0.9))
.withPromptContributor(Personas.WRITER);

return runner.createObject(String.format("""
Craft a short story in %d words or less.
The story should be engaging and imaginative.
Use the user's input as inspiration if possible.
Expand All @@ -154,8 +155,8 @@ Story craftStory(UserInput userInput) {
# User input
%s
""",
storyWordCount,
userInput.getContent()
).trim(), Story.class);
storyWordCount,
userInput.getContent()
).trim(), Story.class);
}
}
17 changes: 12 additions & 5 deletions src/test/java/com/embabel/template/agent/WriteAndReviewAgentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.embabel.agent.domain.io.UserInput;
import com.embabel.agent.testing.unit.FakeOperationContext;
import com.embabel.agent.testing.unit.FakePromptRunner;
import com.embabel.agent.testing.unit.UnitTestUtils;
import org.junit.jupiter.api.Test;

Expand All @@ -14,12 +15,18 @@ class WriteAndReviewAgentTest {

@Test
void testWriteAndReviewAgent() {
var context = FakeOperationContext.create();
var promptRunner = (FakePromptRunner) context.promptRunner();
context.expectResponse(new Story("One upon a time Sir Galahad . . "));

var agent = new WriteAndReviewAgent(200, 400);
var llmCall = UnitTestUtils.captureLlmCall(() -> {
agent.craftStory(new UserInput("Tell me a story about a brave knight", Instant.now()));
});
assertTrue(llmCall.getPrompt().contains("knight"), "Expected prompt to contain 'knight'");
assertEquals(0.9, llmCall.getLlm().getTemperature(), 0.01,
agent.craftStory(new UserInput("Tell me a story about a brave knight", Instant.now()), context);

String prompt = promptRunner.getLlmInvocations().getFirst().getPrompt();
assertTrue(prompt.contains("knight"), "Expected prompt to contain 'knight'");

var temp = promptRunner.getLlmInvocations().getFirst().getInteraction().getLlm().getTemperature();
assertEquals(0.9, temp, 0.01,
"Expected temperature to be 0.9: Higher for more creative output");
}

Expand Down