Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the Maven Wrapper to the project, enabling a consistent Maven version across environments and simplifying build and runtime dependencies. Key changes include adding Maven Wrapper scripts, updating the build process to use the wrapper, and configuring the wrapper properties.
Maven Wrapper Integration:
Added
mvnwandmvnw.cmdscripts for Unix and Windows environments, respectively, to enable the use of the Maven Wrapper for managing Maven versions. These scripts include logic for downloading and validating the Maven distribution. [1] [2]Included
maven-wrapper.propertiesin the.mvn/wrapperdirectory to configure the Maven Wrapper. It specifies the Maven version (3.9.6) and the distribution URL for downloading Maven.Build Process Updates:
Updated
scripts/shell.shto replace direct Maven calls with the Maven Wrapper (mvnw). This ensures the specified Maven version is used during the build process.Modified
scripts/support/agent.batandscripts/support/agent.shto use the Maven Wrapper (mvnw.cmdandmvnw, respectively) instead of directly invoking Maven. [1] [2]