Make shell.sh invocable from the root directory#22
Merged
alexheifetz merged 1 commit intoembabel:mainfrom Jul 15, 2025
Merged
Conversation
Currently, developers must switch to the scripts directory before invoking shell.sh, which is one extra command. Also, calling ./scripts/shell.sh fails due to the assumption that it is run in the scripts directory. This change makes shell.sh/bat robust against the invoking directory.
ramnivas
force-pushed
the
robust-shell-sh
branch
from
1b065d2 to
c6e1231
Compare
Contributor
Author
|
Please note that I don't have access to a Windows machine, so could not test shell.bat. |
alexheifetz
approved these changes
Jul 15, 2025
Contributor
alexheifetz
left a comment
alexheifetz
left a comment
There was a problem hiding this comment.
Thanks Ramnivas. I will merge and adjust Windows script accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, developers must switch to the scripts directory before invoking shell.sh, which is one extra command. Also, calling ./scripts/shell.sh fails due to the assumption that it is run in the scripts directory.
This change makes shell.sh/bat robust against the invoking directory.