Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new instrumentation layer for Spring AI chat model calls, enabling automatic emission of
ChatModelCallEventwith the fully augmented prompt at the exact point the model is invoked. The change eliminates manual event emission at multiple call sites and ensures accurate event capture. The implementation uses a decorator (InstrumentedChatModel) and updates the client creation logic to support this. Comprehensive tests verify correct behavior and interface compliance.Instrumentation and event emission improvements:
InstrumentedChatModelclass to wrapChatModeland emit aChatModelCallEventwith the final prompt duringcall()invocation, ensuring domain context is captured and event emission is centralized. (embabel-agent-api/src/main/kotlin/com/embabel/agent/spi/support/springai/InstrumentedChatModel.kt)ChatClientLlmOperations.createChatClientto accept an optionalllmRequestEventand useInstrumentedChatModelwhen provided, replacing manual event emission at each call site with transparent instrumentation. (embabel-agent-api/src/main/kotlin/com/embabel/agent/spi/support/springai/ChatClientLlmOperations.kt) [1] [2] [3] [4] [5]ChatClientLlmOperations, as instrumentation is now handled by the decorator. (embabel-agent-api/src/main/kotlin/com/embabel/agent/spi/support/springai/ChatClientLlmOperations.kt) [1] [2] [3]Testing and validation:
InstrumentedChatModel, verifying correct delegation, event emission, error propagation, and interface contract compliance. (embabel-agent-api/src/test/kotlin/com/embabel/agent/spi/support/springai/InstrumentedChatModelTest.kt)