Add OTel context cleanup to ChatModelObservationFilterTest#1409
Merged
alexheifetz merged 1 commit intomainfrom Feb 13, 2026
Merged
Add OTel context cleanup to ChatModelObservationFilterTest#1409alexheifetz merged 1 commit intomainfrom
alexheifetz merged 1 commit intomainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with test context isolation in
ChatModelObservationFilterTest.javaby ensuring that OpenTelemetry (OTel) context does not leak between tests. The changes introduce explicit management of the OTel root context scope in the hierarchy integration tests.Test context isolation improvements:
ContextandScopefrom the OpenTelemetry API to allow explicit context management in tests.Scopefield (otelRootScope) to the test class and initialized it with a clean OTel root context in the@BeforeEachsetup method to prevent cross-test context leakage.otelRootScopein the@AfterEachteardown method.