fix: fix the docs about schema, global schema using guard#283
Merged
SaltyAom merged 2 commits intoelysiajs:mainfrom Apr 23, 2024
Merged
fix: fix the docs about schema, global schema using guard#283SaltyAom merged 2 commits intoelysiajs:mainfrom
SaltyAom merged 2 commits intoelysiajs:mainfrom
Conversation
SaltyAom
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix #270,
There is already a pr #215, does not seems to be as required.
I have also removed the info about "the order of code", as there are not code to have side effect with validation. And if multiple schemas are defined, the latest one is used to validate the data.
It fixes the example snippet, but please review if the descriptions matches and does not add any confusion.
Discord thread: https://discord.com/channels/1044804142461362206/1202502724911112242