Correct decoding of "dynamic" objects.#2
Open
remyoudompheng wants to merge 2 commits intoelobuff:masterfrom
Open
Correct decoding of "dynamic" objects.#2remyoudompheng wants to merge 2 commits intoelobuff:masterfrom
remyoudompheng wants to merge 2 commits intoelobuff:masterfrom
Conversation
added 2 commits
October 8, 2017 21:19
This scenario typically happens when decoding a dynamic Object. The reader is allowed to return an EOF error in such a case, which should not be considered as a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic objects end with an empty string. The current code for reading empty strings will fail at the end of a bytes.Reader, which is a typical use case (including unit tests).