Operation GAC (Silverado Tuning) #470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 20 segments for: GMC_ACADIA, GMC_YUKON ✅ 0 changed, 20 passed, 0 errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation
This adds offset into the non-linear tune and remaps the silverado's sigmoid for better accuracy. Other affected cars are the bolt and acadia. I have used offset on 100ish bolts for over a year without issue, so no problems there. I could probably track down an acadia to test if ya'll are worried about it. Based on what I've seen for GM lateral, this would enhance their tuning as well.