Override content disposition with provided filename#137
Open
bolek wants to merge 1 commit intoelixir-waffle:masterfrom
Open
Override content disposition with provided filename#137bolek wants to merge 1 commit intoelixir-waffle:masterfrom
bolek wants to merge 1 commit intoelixir-waffle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When provided to
store/1%{filename: "some file.png", remote_path: "https://example.com/file"}and the remote_path returns a content disposition header,
we get a unhandled CaseClause exception
example:
elixir
This PR fixes the above, by adding a case clause. It will use the provided
filenamerather than the filenamereturned in the content disposition header.