Fix uploads for files larger than 2GB #105
Open
sulphur wants to merge 2 commits intoelixir-waffle:masterfrom
Open
Fix uploads for files larger than 2GB #105sulphur wants to merge 2 commits intoelixir-waffle:masterfrom
sulphur wants to merge 2 commits intoelixir-waffle:masterfrom
Conversation
achempion
approved these changes
Sep 5, 2022
Member
achempion
left a comment
achempion
left a comment
There was a problem hiding this comment.
Good catch 👍 Thank you for the provided fix
| body | ||
| |> StringIO.open() | ||
| |> elem(1) | ||
| |> IO.binstream(1024*1024*10) |
Author
There was a problem hiding this comment.
It is arbitrary. I'm using 10MB chunks to write to files. When to small it can be long when to high it will use to much memory i figured 10Mb is good compromise today. I don't know what would be best here :)
|
@achempion Is this PR expected to be merged soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Currently Waffle ( well erlang's
:file.writewhich Elixir'sFile.writeuses) fails to writes files greater than 2GB and as such we can't upload files larger than 2GB. This PR uses stream to write instead.