Skip to content

html: improve consistency across private helpers#2196

Merged
milmazz merged 1 commit intomainfrom
milton/html-review
Feb 9, 2026
Merged

html: improve consistency across private helpers#2196
milmazz merged 1 commit intomainfrom
milton/html-review

Conversation

@milmazz
Copy link
Member

@milmazz milmazz commented Feb 9, 2026

Most of these changes are similar to the ones I did in #2181, a good summary of the specific changes could be the following:

  • Change most of the private helpers to accept the config value as the first argument
  • Transform generate_redirect/3 to a private helper, is not referenced elsewhere.
  • Sprinkle some Path.join/2 instead of explicit paths.
  • introduce the write!/3 private helper as in formatter/markdown.ex

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

@milmazz milmazz marked this pull request as ready for review February 9, 2026 03:57
@milmazz milmazz merged commit 017a90a into main Feb 9, 2026
12 checks passed
@milmazz milmazz deleted the milton/html-review branch February 9, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments