Alertmanager configuration template revamp #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rohit01
commented
Feb 19, 2016
rohit01
commented
Comprehensive to handle most of the use cases
elijah
reviewed
Dec 15, 2016
Owner
elijah
left a comment
elijah
left a comment
There was a problem hiding this comment.
I think I merged a patch a few minutes ago that also alters the alertmanager configuration, and that was more compact than this one - a loop in the template so that it will iterate over the list of all outstanding alert methods, and only activate the ones that are configured.
Could you rebase off of master and work that out?
Thanks,
--e
elijah
requested changes
Dec 15, 2016
Owner
elijah
left a comment
elijah
left a comment
There was a problem hiding this comment.
Please rebase off of current master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.