Skip to content

Comments

Updating ternary logic for hits/misses graphic#61

Open
emerham wants to merge 1 commit intoelijaa:masterfrom
emerham:hits-misses-graphic
Open

Updating ternary logic for hits/misses graphic#61
emerham wants to merge 1 commit intoelijaa:masterfrom
emerham:hits-misses-graphic

Conversation

@emerham
Copy link

@emerham emerham commented Jan 31, 2020

Fixes for issue #60

@mustangxu
Copy link

This fix works, pls pull

@PHPGangsta
Copy link

It might work, but it doesn't make sense 😄

Why is there (still) an assignment (single "=") in it? Why is it overwriting the content of the variable $stats['get_hits_percent']?

I fixed the issue by adding a second equal-sign:

<?php echo $stats['get_hits_percent'] == ' - ' ? '' : 'y: ' . $stats['get_hits_percent'] . ','; ?>

Now it's a comparison instead of an assignment. I guess that's what's intended here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants